Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] polars complete function #1367

Merged
merged 78 commits into from
Jun 14, 2024
Merged

[ENH] polars complete function #1367

merged 78 commits into from
Jun 14, 2024

Conversation

samukweku
Copy link
Collaborator

@samukweku samukweku commented May 24, 2024 •
edited
Loading

PR Description

Please describe the changes proposed in the pull request:

  • Add complete method for polars

This PR relates to #1352 .

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.md.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

samuel.oranyeli and others added 30 commits April 19, 2024 18:32
add make_clean_names function that can be applied to polars
862c7dd
add examples for make_clean_names
01531cc
changelog
0fb440e
limit import location for polars
5e944b2
limit import location for polars
501d9c6
fix polars in environment-dev.yml
9506832
install polars in doctest
1ae8edd
limit polars imports - user should have polars already installed
3b1829b
use subprocess.run
52fd80c
add subprocess.devnull to docstrings
2dce78b
add subprocess.devnull to docstrings
37b3feb
add subprocess.devnull to docstrings
0953f2d
add subprocess.devnull to docstrings
d7c71b6
add os.devnull
40b8502
add polars as requirement for docs
4f11d09
add polars to tests requirements
54b179c
delete irrelevant folder
25b39b9
changelog
a09f34b
create submodule for polars
1b375f8
fix doctests
799532f
fix tests; add polars to documentation
dbce4b9
fix tests; add polars to documentation
1c642e6
import janitor.polars
407d21b
control docs output for polars submodule
aedfc65
exclude functions in docs rendering
db9b486
exclude functions in docs rendering
6a91e67
show_submodules=true
7a88078
fix docstring rendering for polars
6d7885e
Expression -> expression
944fa02
@ericmjl
Merge dev into samukweku/polars_clean_names
b9aefaa
@codecov Codecov
Copy link

codecov bot commented May 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.05263% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.93%. Comparing base (62c57c6) to head (af09c7a).
Report is 19 commits behind head on dev.

❗ Current head af09c7a differs from pull request most recent head 0f24a6e

Please upload reports for the commit 0f24a6e to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1367      +/-   ##
==========================================
- Coverage   94.48%   85.93%   -8.55%     
==========================================
  Files          80       83       +3     
  Lines        4367     4820     +453     
==========================================
+ Hits         4126     4142      +16     
- Misses        241      678     +437

ericmjl
ericmjl approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@ericmjl ericmjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you @samukweku!

@ericmjl ericmjl merged commit d912a5e into dev Jun 14, 2024
4 checks passed
@ericmjl ericmjl deleted the samukweku/polars_complete branch June 14, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmjl ericmjl ericmjl approved these changes

@Zeroto521 Zeroto521 Awaiting requested review from Zeroto521

@thatlittleboy thatlittleboy Awaiting requested review from thatlittleboy

Assignees

@samukweku samukweku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samukweku @ericmjl